Re: [PATCH RFC tip/core/rcu 32/41] rcu: Update stall-warningdocumentation

[Paul E. McKenney]

On Wed, Feb 01, 2012 at 09:56:39PM -0800, Josh Triplett wrote:
> On Wed, Feb 01, 2012 at 11:41:50AM -0800, Paul E. McKenney wrote:
> > From: "Paul E. McKenney" <paul.mckenney@xxxxxxxxxx>
> > 
> > Add documentation of CONFIG_RCU_CPU_STALL_VERBOSE, CONFIG_RCU_CPU_STALL_INFO,
> > and RCU_STALL_DELAY_DELTA.  Describe multiple stall-warning messages from
> > a single stall, and the timing of the subsequent messages.  Add headings.
> 
> Don't some of these documentation changes go with earlier patches in
> this series?

Some could, but there is a fair amount of catch-up here.  Since we don't
need documentation to be bisectable, it makes sense to do a single
commit to update the documentation.

> Also, this commit message doesn't say anything about the removal of
> RCU_SECONDS_TILL_STALL_RECHECK:
> 
> > --- a/Documentation/RCU/stallwarn.txt
> > +++ b/Documentation/RCU/stallwarn.txt
> > @@ -14,12 +14,36 @@ CONFIG_RCU_CPU_STALL_TIMEOUT
> >  	issues an RCU CPU stall warning.  This time period is normally
> >  	ten seconds.
> >  
> > -RCU_SECONDS_TILL_STALL_RECHECK
> [...]
> > -	This macro defines the period of time that RCU will wait after
> > -	issuing a stall warning until it issues another stall warning
> > -	for the same stall.  This time period is normally set to three
> > -	times the check interval plus thirty seconds.

It is now computed from CONFIG_RCU_CPU_STALL_TIMEOUT, which has an old
value for default, which is now fixed.  I will add the rationale for
removing CONFIG_RCU_SECONDS_TILL_STALL_RECHECK to the commit message.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/