Re: [PATCH v2 1/3] KVM: x86: move kvm_exit related definitions intokvm_exit.h

From: Xiao Guangrong
Date: Thu Feb 02 2012 - 12:48:27 EST


On 02/03/2012 01:30 AM, Avi Kivity wrote:

> On 02/02/2012 07:26 PM, Xiao Guangrong wrote:
>> From: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx>
>>
>> Move the definitions into a separate .h file so that 'perf kvm-events' can
>> easily use these
>
> Why not just include vmx.h and svm.h? I don't like scattering those
> definitions around.
>


Err, if we directly include "vmx.h" and "svm.h" we should use
"#ifdef __KERNEL__" to split the definition, it is ugly i think,
but i do not have strong opinion on it, i will switch to your way :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/