Re: [PATCH 01/16] blkcg: make CONFIG_BLK_CGROUP bool
From: Tejun Heo
Date: Thu Feb 02 2012 - 12:14:19 EST
On Thu, Feb 02, 2012 at 02:53:57PM +0800, Li Zefan wrote:
> Tejun Heo wrote:
> > Block cgroup core can be built as module; however, it isn't too useful
> > as blk-throttle can only be built-in and cfq-iosched is usually the
> > default built-in scheduler. Scheduled blkcg cleanup requires calling
> > into blkcg from block core. To simplify that, disallow building blkcg
> > as module by making CONFIG_BLK_CGROUP bool.
> > If building blkcg core as module really matters, which I doubt, we can
> > revisit it after blkcg API cleanup.
> > -v2: Vivek pointed out that IOSCHED_CFQ was incorrectly updated to
> > depend on BLK_CGROUP. Fixed.
> > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> > Cc: Vivek Goyal <vgoyal@xxxxxxxxxx>
> > ---
> > block/Kconfig.iosched | 4 ----
> > block/blk-cgroup.c | 17 -----------------
> > block/blk-cgroup.h | 10 ++--------
> > init/Kconfig | 2 +-
> > 4 files changed, 3 insertions(+), 30 deletions(-)
> You can merge the following change with your patch.
Nice, will do.
> Moreover, some cgroup APIs were exported to allow blk-cgroup to be built
> as a module, and now they can be unexported.
Yeah, that would be nice too. Let's think about that after this whole
block thing settles down.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/