Re: [RFC 2/7] MFD: twl6040: Convert to i2c driver, and separate itfrom twl core

From: Mark Brown
Date: Thu Feb 02 2012 - 08:27:58 EST

On Thu, Feb 02, 2012 at 03:01:06PM +0200, Peter Ujfalusi wrote:
> On 02/02/2012 02:48 PM, Mark Brown wrote:

> > The calling convention here seems a bit weird too, you've got value then
> > register but normally we have register then value for I2C/SPI devices.

> I have based these part on the twl-core's implementation. I should not
> have done that, I know.. Let's see how it will look like with regmap.

Yeah, like I say...

> > Except when we don't :('s not like we've been consistent so far. I'm not that fussed
either way, I probably wouldn't have mentioned it if I hadn't otherwise
been commenting.

Attachment: signature.asc
Description: Digital signature