Re: [PATCH v4 1/3] virtio-scsi: first version

From: Christian Hoff
Date: Thu Feb 02 2012 - 07:48:02 EST


Hallo Paolo,

Paolo Bonzini wrote:
> + cmd->req.cmd = (struct virtio_scsi_cmd_req){
> + .lun[0] = 1,
> + .lun[1] = sc->device->id,
> + .lun[2] = (sc->device->lun >> 8) | 0x40,
> + .lun[3] = sc->device->lun & 0xff,
> + .tag = (unsigned long)sc,
> + .task_attr = VIRTIO_SCSI_S_SIMPLE,
> + .prio = 0,
> + .crn = 0,
> + };

just wondering why you truncate target IDs to one byte? Also, why do you
limit LUN numbers to 16 bits?

Also will it be possible to extend virtio-scsi to support more than one
HBA without changing the ABI?

Other than that the patch looks good and I have been using virtio-scsi
successfully for some time now on my private clone of qemu.

Mit freundlichen Grüßen / Kind regards Christian Hoff
-----------------------------------------------------------------------------------------------------------------------------------
IBM Deutschland
Am Fichtenberg
171083 Herrenberg
-----------------------------------------------------------------------------------------------------------------------------------
IBM Deutschland GmbH / Vorsitzender des Aufsichtsrats: Martin
JetterGeschäftsführung: Martina Koederitz (Vorsitzende), Reinhard Reschke,
Dieter Scholz, Michael Diemer, Gregor PillenSitz der Gesellschaft:
Ehningen / Registergericht: Amtsgericht Stuttgart, HRB 14562 /
WEEE-Reg.-Nr. DE 99369940

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/