Re: [PATCH] Regression: Revert "Bluetooth: use buffer priority tomark URB_ISO_ASAP flag"

From: Pavel Machek
Date: Thu Feb 02 2012 - 05:51:10 EST


> This reverts commit b8aabfc92249b239c425da7e4ca85b7e4855e984.
> URB_ISO_ASAP may only be used with iso end points, but this patch was
> attempting to use it with a bulk endpoint. When DEBUG is defined in
> the USB stack, it checks for invalid flags and returns -EINVAL instead
> of actually transmitting the data.
> Signed-off-by: Keith Packard <keithp@xxxxxxxxxx>

This patch fixes a regression, and it is not in 3.3.0-rc2.

(And for the record I also believe that #ifdef debug should not
introduce extra error returns. WARN_ON() should be enough. Don't break
systems for people who try to be nice and enable debugging.)
(cesky, pictures)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at