Re: [PATCH -v2 0/7] PCI: pcie hotplug related patch

From: Kenji Kaneshige
Date: Thu Feb 02 2012 - 05:01:10 EST

Yinghai, Jesse,

I tested pciehp with your set of patches. I have some comments below.

(1) I got a following warning message on compiling the patch [5/7].

drivers/pci/hotplug/pciehp_hpc.c:281: warning: 'pcie_wait_link_not_active' defined but not used

(2) I got following warning messages on compiling the patch [6/7]

drivers/pci/hotplug/pciehp_hpc.c:381: warning: 'pciehp_link_enable' defined but not used
drivers/pci/hotplug/pciehp_hpc.c:386: warning: 'pciehp_link_disable' defined but not used

(3) I've asked Naoki Yanagimoto, who reported that configuration read
on some hot-added PCIe device returns invalid value, to test the
patch. Unfortunately, the problem happens with your patch. But
after some discussion and testing, it turned out that problem doesn't
happen when the same card with updated bios is used. So it seems the
problem is in PCIe card side.

As a result, problems I found are (1) and (2). Please fix those.
Other than that, pciehp seems to work well.

Tested-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>

Kenji Kaneshige

(2012/01/28 3:55), Yinghai Lu wrote:
75e4615: pciehp: Disable/enable link during slot power off/on
92bdfaf: pciehp: Add Disable/enable link functions
47442c1: pciehp: Add pcie_wait_link_not_active()
40b6c9b: pciehp: print out link status when dlla get active.
dcc66b6: pciehp: Checking pci conf reading to new added device instead of sleep 1s
aadd74c: PCI: Separate pci_bus_read_dev_vendor_id from pci_scan_device
e7457be: PCI: Make sriov work with hotplug remove

drivers/pci/hotplug/pciehp_hpc.c | 133 +++++++++++++++++++++++++++++++-------
drivers/pci/pci.h | 2 +
drivers/pci/probe.c | 48 +++++++++-----
drivers/pci/remove.c | 10 +++-
4 files changed, 151 insertions(+), 42 deletions(-)

First one is for hotplug with sriov under bridge.
following two are for hotplug probing with pci conf reading.
Last four are for pcie link disable when power off slots.

-v2: update first one according to reviewing from linus.
other like pci_dev_read_config return checking is not changed.

Resending whole set according to Jesse.


Yinghai Lu
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at