Re: [PATCH RFC tip/core/rcu 13/41] rcu: Make rcutorture flagonline/offline failures

[Josh Triplett]

On Wed, Feb 01, 2012 at 11:41:31AM -0800, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paul.mckenney@xxxxxxxxxx>
> 
> Make rcutorture check for CPU-hotplug failures and complain if there
> were any.
> 
> Signed-off-by: Paul E. McKenney <paul.mckenney@xxxxxxxxxx>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> ---
>  kernel/rcutorture.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> index 88f17b8..a94eaef 100644
> --- a/kernel/rcutorture.c
> +++ b/kernel/rcutorture.c
> @@ -1602,6 +1602,10 @@ rcu_torture_cleanup(void)
>  		cur_ops->cleanup();
>  	if (atomic_read(&n_rcu_torture_error))
>  		rcu_torture_print_module_parms(cur_ops, "End of test: FAILURE");
> +	else if (n_online_successes != n_online_attempts ||
> +		 n_offline_successes != n_offline_attempts)
> +		rcu_torture_print_module_parms(cur_ops,
> +					       "End of test: RCU_HOTPLUG");
>  	else
>  		rcu_torture_print_module_parms(cur_ops, "End of test: SUCCESS");

OK, I must admit that when I saw the addition of RCU_HOTPLUG to the
existing cases of FAILURE and SUCCESS, my mind went to
http://thedailywtf.com/Articles/What_Is_Truth_0x3f_.aspx .

More seriously, though, shouldn't this just say FAILURE, perhaps with
further explanation attached?

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/