Re: [PATCH] NVMe: Fix compilation on architecturs without readq/writeq
From: Linus Torvalds
Date: Wed Feb 01 2012 - 18:36:02 EST
On Tue, Jan 31, 2012 at 4:23 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> non-atomic sounds good to me too.
You both apparently missed the related discussion that some devices
really do care about order, even if they don't care about atomicity.
So we'd actually have two versions of the header file, one
little-endian, and one big-endian. Then the driver that knows it
doesn't need the atomic 'readq()' that is always defined, but wants a
low-bytes-first version would just do
(or "big-endian" if it wants to read/write high bits first). Most
drivers probably don't care, but apparently NVMe does.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/