Re: [PATCH net-next] net: dev: Convert printks to pr_<level>

From: David Miller
Date: Wed Feb 01 2012 - 14:22:01 EST


From: Joe Perches <joe@xxxxxxxxxxx>
Date: Sun, 29 Jan 2012 16:20:30 -0800

> - pr_warning("Number of in use tx queues changed "
> - "invalidating tc mappings. Priority "
> - "traffic classification disabled!\n");
> + pr_warn(
> +"Number of in use tx queues changed invalidating tc mappings. "
> +"Priority traffic classification disabled!\n");

Don't do things like this. It is never correct to un-indent subsequent
lines of a string like this. And a line ending in "pr_whatever(" looks
terrible.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/