Re: [PATCH 1/4] mfd/ab8500: fix error path bug

From: Maxime Coquelin
Date: Wed Feb 01 2012 - 11:24:21 EST

Hi Linus,

On 02/01/2012 05:09 PM, Linus WALLEIJ wrote:
From: Linus Walleij<linus.walleij@xxxxxxxxxx>

We were not freeing the irq properly in the error path in
the AB8500 driver.

Cc: Mark Brown<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Maxime Coquelin<maxime.coquelin@xxxxxxxxxxxxxx>
Signed-off-by: Alex Macro<alex.macro@xxxxxxxxxxxxxx>
Signed-off-by: Michel Jaouen<michel.jaouen@xxxxxxxxxxxxxx>
Signed-off-by: Linus Walleij<linus.walleij@xxxxxxxxxx>
drivers/mfd/ab8500-core.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index 53e2a80..bf823d2 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -956,9 +956,10 @@ int __devinit ab8500_init(struct ab8500 *ab8500)
return ret;

- if (ab8500->irq_base) {
+ if (ab8500->irq_base)
free_irq(ab8500->irq, ab8500);
+ if (ab8500->irq_base)
Shouldn't the above brace to be removed?
return ret;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at