Re: [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

From: Matthew Garrett
Date: Wed Feb 01 2012 - 09:57:10 EST


On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote:
> This patch adds support for generic cpu thermal cooling low level
> implementations using frequency scaling and cpuhotplugg currently.

We've been over this kind of thing in the past. cpu hotplug is a
relatively expensive operation, so people have previously been
enthusiastic about using the scheduler to simply avoid running anything
on CPUs if they're overheating. Has any general consensus been reached
on this?

I'm also not entirely thrilled at now having two ways to manage the cpu
through the thermal layer. ACPI already plugs in via the passive trip
points. If we're going to do this then I'd like to see the ACPI code
merged in with the generic cpu cooling code.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/