Re: [PATCH V2] gpio: tps65910: Add sleep control support

From: Linus Walleij
Date: Wed Feb 01 2012 - 07:30:52 EST


On Wed, Feb 1, 2012 at 7:39 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:

> The device tps65910/tps65911 supports the sleep
> functionality in some of gpios. If gpio is configured
> in output mode and sleep is enabled then during device
> sleep state, the output of gpio becomes LOW regardless
> of non-sleep output value.
> Such gpio can be used to control regulator switch such
> that output of regulator is off in device sleep state.
>
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> ---
> Changes from V1:
> Taken care of review comments from Linus Walleij's
> - Remove magic numbers and added macro for defining them.
> - Used bool type for the platform's gpio sleep control data.

Thanks, looks good!
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/