Re: [PATCH 6/6] cls_cgroup: remove redundant rcu_read_lock/unlock

From: David Miller
Date: Wed Feb 01 2012 - 02:11:14 EST


From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Wed, 01 Feb 2012 08:07:19 +0100

> Then, I wonder why we do the "if (classid && classid != sk->sk_classid)"
>
> before the :
>
> sk->sk_classid = classid;
>
> This seems unnecessary checks.
>

Avoiding dirtying the sk->sk_classid cache line unnecessarily?

I actually have no idea actually how often this routine can get
invoked in real world scenerios.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/