Re: [PATCH 2/2] remoteproc: s/big switch/lookup table/

[Jack Stone]

On 31/01/12 16:52, Ohad Ben-Cohen wrote:
> +/*
> + * A lookup table for resource handlers. Always keep in sync with
> + * enum fw_resource_type.
> + */
> +static rproc_handle_resource_t rproc_handle_rsc[] = {
> +	rproc_handle_carveout,	/* RSC_CARVEOUT */
> +	rproc_handle_devmem,	/* RSC_DEVMEM */
> +	rproc_handle_trace,	/* RSC_TRACE */
> +	rproc_handle_vring,	/* RSC_VRING */
> +	NULL, /* RSC_VIRTIO_DEV is handled early upon registration */
> +};
> +

You could change this to

[RSC_CARVEOUT] = rproc_handle_carveout,

Then you would be safe against renumbering and would only need to worry
about addition (which your RSC_LAST check copes with).

Thanks,

Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/