Re: [PATCH v2 4/8] staging: tidspbridge: silence the compiler

[Dan Carpenter]

On Tue, Jan 31, 2012 at 12:19:52PM +0100, Víctor M. Jáquez L. wrote:
> On Tue, Jan 31, 2012 at 11:05:43AM +0300, Dan Carpenter wrote:
> > On Tue, Jan 31, 2012 at 12:12:20AM +0100, Víctor Manuel Jáquez Leal wrote:
> > > Silence the warning when compiling drv_interface.c
> > > 
> > > Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@xxxxxxxxxx>
> > 
> > What does the compiler warn about here?  Normally you would cut and
> > paste the warning into the commit message.  But at least give us a
> > hint.
> > 
> > You could also reformat that printk so the message is on one line.
> > 
> > 	dev_dbg(bridge,
> > 	        "%s: vm filp %p offset %x start %lx end %lx page_prot %ulx flags %lx\n",
> > 		__func__, filp, offset, vma->vm_start, vma->vm_end,
> > 		vma->vm_page_prot, vma->vm_flags);
> 
> Ok. I'll do it.
> 
> I have a doubt about the process in this case: if this is the only
> modification request, should I resend all the patch set, or just this one?
> 

If you sent just the one, and you redid the printk() then it would
make the later patches not apply.

Maybe just send the one, with a fixed changelog and leave the patch
as is.  The problems in the printk() were not introduced in this
patch so I can't really complain about that.  A couple people have
already volunteered to fix that in a later patch.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature