Re: [PATCH v2 5/7] LPC32xx: clock.c: warning fix

From: Wolfram Sang
Date: Tue Jan 31 2012 - 05:27:02 EST


On Mon, Jan 30, 2012 at 05:02:04PM +0100, Roland Stigge wrote:
> This patch removes the debug warning on local_clk_disable() as done in Kevin
> Wells' driver update
>
> Signed-off-by: Roland Stigge <stigge@xxxxxxxxx>

Maybe this can be folded with 7/7? Otherwise

Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
Tested-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

>
> diff --git a/arch/arm/mach-lpc32xx/clock.c b/arch/arm/mach-lpc32xx/clock.c
> index 229bec5..01e9aba 100644
> --- a/arch/arm/mach-lpc32xx/clock.c
> +++ b/arch/arm/mach-lpc32xx/clock.c
> @@ -903,8 +903,6 @@ static inline void clk_unlock(void)
>
> static void local_clk_disable(struct clk *clk)
> {
> - WARN_ON(clk->usecount == 0);
> -
> /* Don't attempt to disable clock if it has no users */
> if (clk->usecount > 0) {
> clk->usecount--;

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature