Re: sched: fix compilation warning on !SMP
From: Vincent Guittot
Date: Tue Jan 31 2012 - 03:46:15 EST
2012/1/31 Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>:
> From: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
>
> CC kernel/sched/fair.o
> kernel/sched/fair.c:218:36: warning: 'max_load_balance_interval' defined but not used [-Wunused-variable]
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
> CC: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> CC: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> ---
> kernel/sched/fair.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 8e77a6b..4ab60a2 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -215,8 +215,6 @@ calc_delta_mine(unsigned long delta_exec, unsigned long weight,
>
> const struct sched_class fair_sched_class;
>
> -static unsigned long __read_mostly max_load_balance_interval = HZ/10;
> -
> /**************************************************************
> * CFS operations on generic schedulable entities:
> */
> @@ -3086,6 +3084,8 @@ static bool yield_to_task_fair(struct rq *rq, struct task_struct *p, bool preemp
> * Fair scheduling class load-balancing methods:
> */
>
> +static unsigned long __read_mostly max_load_balance_interval = HZ/10;
> +
Sorry for moving it out of SMP. Thanks for fixing this
> /*
> * pull_task - move a task from a remote runqueue to the local runqueue.
> * Both runqueues must be locked.
> --
> 1.7.7.6
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/