Re: [PATCH] Cleanup of rw_copy_check_uvector andcompat_rw_copy_check_uvector

[Andrew Morton]

On Mon, 30 Jan 2012 18:23:37 +0100
Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> On 01/30, Christopher Yeoh wrote:
> >
> >  ssize_t compat_rw_copy_check_uvector(int type,
> >  		const struct compat_iovec __user *uvector, unsigned long nr_segs,
> >  		unsigned long fast_segs, struct iovec *fast_pointer,
> > -		struct iovec **ret_pointer, int check_access)
> > +		struct iovec **ret_pointer)
> >  {
> >  	compat_ssize_t tot_len;
> >  	struct iovec *iov = *ret_pointer = fast_pointer;
> > @@ -586,7 +586,7 @@ ssize_t compat_rw_copy_check_uvector(int type,
> >  		}
> >  		if (len < 0)	/* size_t not fitting in compat_ssize_t .. */
> >  			goto out;
> > -		if (check_access &&
> > +		if (type >=0 &&
> 
> I bet checkpatch.pl will complain, this needs the space after '>' ;)
> 
> Otherwise this is nice cleanup, imho.
> 
> Christopher, this is up to Andrew but perhaps you should update
> the changelog. It should explain what this patch does (overload
> "int type", remove the unnecessary "check_access", etc). It should
> not simply mention the previous discussion.
> 

Yes please.  Put oneself in the position of a developer reading the
changelog two years from now.

Also, please use our conventional comment layout style in fs.h.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/