Re: [PATCH] perf tools: remove .. in perf includes/

From: Andi Kleen
Date: Mon Jan 30 2012 - 16:45:12 EST


On 1/30/2012 11:14 AM, Arnaldo Carvalho de Melo wrote:
Em Fri, Jan 20, 2012 at 12:36:44PM -0800, Andi Kleen escreveu:
From: Andi Kleen<ak@xxxxxxxxxxxxxxx>

The perf user space has a lot of includes with ugly .. chains. This also
makes it impossible to include any perf files from other code.

I think the original reason for this were some wrapper include files
for the kernel includes, and the explicit paths were needed to avoid
endless recursion. A better way to handle this is #include_next

- Add all the relevant directories as -I in the Makefile
- Remove (near) all the .. in include statements
- Remove unnecessary wrappers that do nothing
- Fix up some fallout

This makes the code more pleasant to read.

I did it all in one big patch to keep bisectability.
It builds, but breaks this:

Hmm cannot reproduce. The extra tarball builds fine and includes memset_64.S
with my patch on Linus latest.

-Andi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/