Re: [PATCH 1/2] um: Use generic io.h

From: Al Viro
Date: Mon Jan 30 2012 - 14:32:42 EST


On Mon, Jan 30, 2012 at 07:25:52PM +0000, Al Viro wrote:

> While we are at it, param.h and pci.h appear to be candidates for the
> same treatment, along with delay.h and auxvec.h. mutex.h as well...
> BTW, we probably can kill arch/um/include/asm/asm-offsets.h - everything
> in there is using generated/asm-offsets.h directly.
>
> FWIW, I'd probably kill current.h as well - replace get_current() in
> arch/um/kernel/process.c with get_current_pid() (i.e. task_pid_nr(current)),
> kill HOST_TASK_PID and switch arch/x86/um/bugs_32.c to use of get_current_pid()
> and we can switch to asm-generic/current.h just fine.

BTW, while looking at those headers - why do we need asm/user.h pulled from
arch/um/include/asm/ptrace-generic.h?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/