Re: [PATCH] x86, reboot: reduce to a single DMI table for rebootquirks

From: Ingo Molnar
Date: Mon Jan 30 2012 - 08:42:22 EST



* Michael D Labriola <mlabriol@xxxxxxxx> wrote:

> > I realize that you only move code here - but it's worth
> > cleaning it up a bit when touching it.
>
> You are requesting that I clean up only the comments that
> appear in the diff, correct? I'll do that as well.

Yeah, and whatever other cleanliness detail you notice: when we
touch some code it is the best opportunity to improve it.

I'd also suggest for ou to do it as two patches: first keep your
existing patch then do a second one on top of it cleaning up any
details, and send me both.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/