[patch v2 7/8]block: fiops add some trace information

From: Shaohua Li
Date: Mon Jan 30 2012 - 02:09:21 EST


Add some trace information, which is helpful when I do debugging.

Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>
---
block/fiops-iosched.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)

Index: linux/block/fiops-iosched.c
===================================================================
--- linux.orig/block/fiops-iosched.c 2012-01-21 10:30:46.000000000 +0800
+++ linux/block/fiops-iosched.c 2012-01-21 10:35:04.000000000 +0800
@@ -10,6 +10,7 @@
#include <linux/jiffies.h>
#include <linux/rbtree.h>
#include <linux/ioprio.h>
+#include <linux/blktrace_api.h>
#include "blk.h"

#define VIOS_SCALE_SHIFT 10
@@ -99,6 +100,11 @@ FIOPS_IOC_FNS(on_rr);
FIOPS_IOC_FNS(prio_changed);
#undef FIOPS_IOC_FNS

+#define fiops_log_ioc(fiopsd, ioc, fmt, args...) \
+ blk_add_trace_msg((fiopsd)->queue, "ioc%d " fmt, (ioc)->pid, ##args)
+#define fiops_log(fiopsd, fmt, args...) \
+ blk_add_trace_msg((fiopsd)->queue, "fiops " fmt, ##args)
+
enum wl_prio_t fiops_wl_type(short prio_class)
{
if (prio_class == IOPRIO_CLASS_RT)
@@ -200,6 +206,8 @@ static void fiops_service_tree_add(struc
ioc->service_tree = NULL;
}

+ fiops_log_ioc(fiopsd, ioc, "service tree add, vios %lld", vios);
+
left = 1;
parent = NULL;
ioc->service_tree = service_tree;
@@ -393,8 +401,12 @@ static struct fiops_ioc *fiops_select_io
* to be starved, don't delay
*/
if (!rq_is_sync(rq) && fiopsd->in_flight[1] != 0 &&
- service_tree->count == 1)
+ service_tree->count == 1) {
+ fiops_log_ioc(fiopsd, ioc,
+ "postpone async, in_flight async %d sync %d",
+ fiopsd->in_flight[0], fiopsd->in_flight[1]);
return NULL;
+ }

return ioc;
}
@@ -405,6 +417,8 @@ static void fiops_charge_vios(struct fio
struct fiops_rb_root *service_tree = ioc->service_tree;
ioc->vios += vios;

+ fiops_log_ioc(fiopsd, ioc, "charge vios %lld, new vios %lld", vios, ioc->vios);
+
if (RB_EMPTY_ROOT(&ioc->sort_list))
fiops_del_ioc_rr(fiopsd, ioc);
else
@@ -498,6 +512,9 @@ static void fiops_completed_request(stru
fiopsd->in_flight[rq_is_sync(rq)]--;
ioc->in_flight--;

+ fiops_log_ioc(fiopsd, ioc, "in_flight %d, busy queues %d",
+ ioc->in_flight, fiopsd->busy_queues);
+
if (fiopsd->in_flight[0] + fiopsd->in_flight[1] == 0)
fiops_schedule_dispatch(fiopsd);
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/