RE: [PATCH] rtc: twl: optimize IRQ bit access

[Venu Byravarasu]

> -----Original Message-----
> From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx]
> Sent: Saturday, January 28, 2012 6:09 AM
> To: Venu Byravarasu
> Cc: a.zummo@xxxxxxxxxxxx; rtc-linux@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] rtc: twl: optimize IRQ bit access
> 
> Are these functions called frequently enough to make this optimisation
> significant?
I did not check how frequent these functions are called.
However, as the values are cached any way, thought of using them before doing hardware access.
> 
> I can see no locking protecting rtc_irq_bits from concurrent updaters.
> Is this code as racy as it appears?
Yes, looks like it is. Will push a separate patch to fix this issue.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/