Re: Slab corruption in floppy driver module

From: Tejun Heo
Date: Sun Jan 29 2012 - 14:36:06 EST


On Fri, Jan 27, 2012 at 02:54:55PM -0500, Vivek Goyal wrote:
> floppy: Fix a crash during rmmmod
>
> floppy driver does not call add_disk() on all the drives hence we don't take
> gendisk reference on request queue for these drives. Don't call put_disk()
> with disk->queue set, otherwise we try to put the reference we never took.
>
> Reported-by: Dirk Gouders <gouders@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Vivek Goyal<vgoyal@xxxxxxxxxx>

Ugh... floppy init is ugly. Thanks for fixing this.

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Jens, this one and the previous one are regression fixes and need to
be routed through v3.3-fixes.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/