Re: REGRESSION 3.2-rcX: RTC auto poweron after 5 minutes

From: Rabin Vincent
Date: Fri Jan 27 2012 - 22:54:24 EST


On Mon, Jan 23, 2012 at 04:31:13PM -0800, John Stultz wrote:
> On Tue, 2011-12-27 at 20:07 +0530, Rabin Vincent wrote:
> > diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c
> > index 3bcc7cf..54a3b5e 100644
> > --- a/drivers/rtc/interface.c
> > +++ b/drivers/rtc/interface.c
> > @@ -778,16 +778,10 @@ static int rtc_timer_enqueue(struct rtc_device
> > *rtc, struct rtc_timer *timer)
> >
> > static void rtc_alarm_disable(struct rtc_device *rtc)
> > {
> > - struct rtc_wkalrm alarm;
> > - struct rtc_time tm;
> > -
> > - __rtc_read_time(rtc, &tm);
> > -
> > - alarm.time = rtc_ktime_to_tm(ktime_add(rtc_tm_to_ktime(tm),
> > - ktime_set(300, 0)));
> > - alarm.enabled = 0;
> > + if (!rtc->ops || !rtc->ops->alarm_irq_enable)
> > + return;
> >
> > - ___rtc_set_alarm(rtc, &alarm);
> > + rtc->ops->alarm_irq_enable(rtc->dev.parent, false);
> > }
> >
>
> Just wanted to close out on this. I know this change worked for
> Andreas, but did it also resolve the original issue for you?

Yes, the original issue remains fixed after this change.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/