Re: [PATCH] module: avoid call vmalloc if init size is zero

From: Rusty Russell
Date: Fri Jan 27 2012 - 16:39:36 EST


On Fri, 27 Jan 2012 11:19:16 +0400, Dmitry Antipov <dmitry.antipov@xxxxxxxxxx> wrote:
> For the architectures with it's own module_alloc(), if module init
> size is zero, avoiding module_alloc_update_bounds() and memset()
> no-op calls also eliminates warn_alloc_failed() zero-size warning
> in __vmalloc_node_range().
>
> Signed-off-by: Dmitry Antipov <dmitry.antipov@xxxxxxxxxx>

Please fix __vmalloc_node_range() instead to return ZERO_SIZE_PTR.
And of course, vfree() to use ZERO_OR_NULL_PTR().

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/