Re: [PATCH 1/7] x86: relocate get/set debugreg fcns toinclude/asm/debugreg.

From: Paul Gortmaker
Date: Fri Jan 27 2012 - 14:29:33 EST


[Re: [PATCH 1/7] x86: relocate get/set debugreg fcns to include/asm/debugreg.] On 27/01/2012 (Fri 12:51) Ingo Molnar wrote:

>
> * Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote:
>
> > Since we already have a debugreg.h header file, move the
> > assoc. get/set functions to it. In addition to it being the
> > logical home for them, it has a secondary advantage. The
> > functions that are moved use BUG(). So we really need to
> > have linux/bug.h in scope. But asm/processor.h is used about
> > 600 times, vs. only about 15 for debugreg.h -- so adding bug.h
> > to the latter reduces the amount of time we'll be processing
> > it during a compile.
> >
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> > CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > CC: Ingo Molnar <mingo@xxxxxxxxxx>
> > CC: "H. Peter Anvin" <hpa@xxxxxxxxx>
> > ---
> > arch/x86/include/asm/debugreg.h | 67 ++++++++++++++++++++++++++++++++++++++
> > arch/x86/include/asm/processor.h | 63 -----------------------------------
> > arch/x86/kernel/cpu/common.c | 1 +
> > 3 files changed, 68 insertions(+), 63 deletions(-)
>
> Acked-by: Ingo Molnar <mingo@xxxxxxx>
>
> I suspect you'd like to carry this in your tree, so that all
> these patches are together?

Yes, that was my original intent, unless there is a consensus
from people indicating that they'd really rather not see such
standalone cleanup trees exist at all.

Thanks,
Paul.

>
> Thanks,
>
> Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/