Re: Probing unconfigured PCI bridge resouces

From: Jesse Barnes
Date: Fri Jan 27 2012 - 12:37:02 EST


On Tue, 24 Jan 2012 15:50:33 +1100
Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, 2012-01-24 at 15:25 +1100, Benjamin Herrenschmidt wrote:
> .../...
>
> > Or am I missing some important fact here ?
>
> Ok, I think I was missing pci_bridge_check_ranges(), gotta figure now
> why this didn't kick in properly for me, probably some arch code
> crackpot.
>
> One thing I noticed is that we do clear IORESOURCE_UNSET in setup-res.c
> when setting up a device resource but we don't clear it for bridges in
> generic code ever, so it leaks all the way through from my early arch
> code. Not a big deal but annoying.

Maybe you can fix that when you unify your arch resource handling code
with the core one day. :)

There have been a lot of changes to handle re-allocation and such, and
I'm sure there's more duplication now...

--
Jesse Barnes, Intel Open Source Technology Center

Attachment: signature.asc
Description: PGP signature