RE: [PATCH 5/5] platform-x86: intel_mid_thermal: turn offthermistor voltage by default

[R, Durgadoss]

> -----Original Message-----
> From: platform-driver-x86-owner@xxxxxxxxxxxxxxx [mailto:platform-driver-x86-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Alan Cox
> Sent: Thursday, January 26, 2012 11:10 PM
> To: mjg@xxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 5/5] platform-x86: intel_mid_thermal: turn off thermistor
> voltage by default
> 
> From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> 
> Instead of complaining that the voltage is on, we can just ask the MSIC to
> turn the voltage off. This should save some power.
> 
> Voltage for thermistors is turned on when ADC conversion is initiated.

Acked-by: Durgadoss R <durgadoss.r@xxxxxxxxx>

Thanks,
Durga

> 
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> ---
> 
>  drivers/platform/x86/intel_mid_thermal.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/platform/x86/intel_mid_thermal.c
> b/drivers/platform/x86/intel_mid_thermal.c
> index aef4979..a4e56be 100644
> --- a/drivers/platform/x86/intel_mid_thermal.c
> +++ b/drivers/platform/x86/intel_mid_thermal.c
> @@ -360,8 +360,10 @@ static int mid_initialize_adc(struct device *dev)
>  	if (ret)
>  		return ret;
> 
> -	if (data & MSIC_ADCTHERM_MASK)
> -		dev_warn(dev, "ADCTHERM already set");
> +	data &= ~MSIC_ADCTHERM_MASK;
> +	ret = intel_msic_reg_write(INTEL_MSIC_ADC1CNTL3, data);
> +	if (ret)
> +		return ret;
> 
>  	/* Index of the first channel in which the stop bit is set */
>  	channel_index = find_free_channel();
> 
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
> in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðÃnÆàþY&—