Re: [PATCH] x86/mce: Replace hard coded hex constants with symbolicdefines

From: Ingo Molnar
Date: Fri Jan 27 2012 - 05:49:33 EST



* Tony Luck <tony.luck@xxxxxxxxx> wrote:

> Magic constants like 0x0134 in code just invite questions on
> where they come from, what they mean, can they be changed?
>
> Provide #defines for the architecturally defined MCACOD values
> with a reference to the Intel Software Developers manual which
> describes them.
>
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---
>
> Ingo: You said "ok up to 100 cols or so" ... this goes to 103.
> If this is OK, you can either apply it from here on top of the
> x86/mce branch in tip - or I can push it to the ras tree and
> send you another pull.

Yeah, looks good to me.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/