RE: [PATCH v1 3/3] ARM: tegra: cpuidle driver for tegra

From: Bedia, Vaibhav
Date: Fri Jan 27 2012 - 03:39:43 EST


On Fri, Jan 27, 2012 at 12:40:58, Colin Cross wrote:
> local_irq_enable() is required by the cpuidle call semantics. See
> arch/arm/process.c, it has a WARN_ON(irqs_disabled()) after the
> idle function call. The local_irq_disable() can and probably should
> be dropped, although a comment that the function is called with
> interrupts off and is expected to return with interrupts on would be
> helpful.
>

Ah... I was too fixated on local_irq_disable() and local_irq_enable() in cpu_idle().
Thanks for clarifying.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/