Re: [PATCH] iommu/msm: Fix error handling in msm_iommu_unmap()

[David Brown]

On Thu, Jan 26, 2012 at 06:29:44PM +0100, Joerg Roedel wrote:
> Error handling in msm_iommu_unmap() is broken. On some error
> conditions retval is set to a non-zero value which causes
> the function to return 'len' at the end. This hides the
> error from the user. Zero should be returned in those error
> cases.
> 
> Cc: David Brown <davidb@xxxxxxxxxxxxxx>
> Cc: Stepan Moskovchenko <stepanm@xxxxxxxxxxxxxx>
> Signed-off-by: Joerg Roedel <joerg.roedel@xxxxxxx>
> ---
>  drivers/iommu/msm_iommu.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)

Acked-by: David Brown <davidb@xxxxxxxxxxxxxx>

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/