RE: [PATCH] scripts: dtc: fix compile warnings

From: Stephen Warren
Date: Thu Jan 26 2012 - 11:59:15 EST


Felipe Balbi wrote at Thursday, January 26, 2012 4:20 AM:
> Fix following compile warnings:
>
> scripts/dtc/flattree.c: In function âflat_read_mem_reserveâ:
> scripts/dtc/flattree.c:700:14: warning: variable âpâ set but not used
> [-Wunused-but-set-variable]
>
> scripts/dtc/dtc.c: In function âmainâ:
> scripts/dtc/dtc.c:104:17: warning: variable âcheckâ set but not used
> [-Wunused-but-set-variable]
>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>

I think you want to send this to the upstream dtc maintainers; I've CC'd
them on this mail.

> ---
> scripts/dtc/dtc.c | 5 +----
> scripts/dtc/flattree.c | 2 --
> 2 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/scripts/dtc/dtc.c b/scripts/dtc/dtc.c
> index 451c92d..2ef5e2e 100644
> --- a/scripts/dtc/dtc.c
> +++ b/scripts/dtc/dtc.c
> @@ -101,7 +101,7 @@ int main(int argc, char *argv[])
> const char *outform = "dts";
> const char *outname = "-";
> const char *depname = NULL;
> - int force = 0, check = 0, sort = 0;
> + int force = 0, sort = 0;
> const char *arg;
> int opt;
> FILE *outf = NULL;
> @@ -143,9 +143,6 @@ int main(int argc, char *argv[])
> case 'f':
> force = 1;
> break;
> - case 'c':
> - check = 1;
> - break;
> case 'q':
> quiet++;
> break;
> diff --git a/scripts/dtc/flattree.c b/scripts/dtc/flattree.c
> index ead0332..28d0b23 100644
> --- a/scripts/dtc/flattree.c
> +++ b/scripts/dtc/flattree.c
> @@ -697,7 +697,6 @@ static struct reserve_info *flat_read_mem_reserve(struct inbuf *inb)
> {
> struct reserve_info *reservelist = NULL;
> struct reserve_info *new;
> - const char *p;
> struct fdt_reserve_entry re;
>
> /*
> @@ -706,7 +705,6 @@ static struct reserve_info *flat_read_mem_reserve(struct inbuf *inb)
> *
> * First pass, count entries.
> */
> - p = inb->ptr;
> while (1) {
> flat_read_chunk(inb, &re, sizeof(re));
> re.address = fdt64_to_cpu(re.address);
> --
> 1.7.8.2

--
nvpublic

èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—