Re: [PATCH 5/9] perf: Add sysfs format attribute for pmu device

[Peter Zijlstra]

On Mon, 2012-01-16 at 13:31 +0100, Jiri Olsa wrote:
> Adding 'format' attribute for pmu device that contains
> a syntax description on how to construct raw events.
> 
> The event configuration is described in following
> struct pefr_event_attr attributes:
> 
>   config
>   config1
>   config2
> 
> Each line of the format file describes mapping of name
> and bitfield definition within one of abve attributes.
> 
> eg:
>   event   config:0-7
>   umask   config:8-15
>   usr     config:16
>   os      config:17
>   edge    config:18
>   any     config:21
>   inv     config:23
>   cmask   config:24-31
> 
> Line syntax:
>   line:      NAME config ':' bits
>   config:    'config' | 'config1' | 'config2"
>   bits:      bits ',' bit_term | bit_term
>   bit_term:  VALUE '-' VALUE | VALUE
> 
> Adding event_format callback to the struct pmu, which provides
> the format information. The pmu shall override this function
> and provide its own specific format information.
> 
> If not overloaded the default format information is used:
> 
>   config  config:0-63
>   config1 config1:0-63
>   config2 config2:0-63 

Shouldn't config[012] be hard-coded like period? They are struct
perf_event_attr members after all and it doesn't really make sense to
have them dynamic if we're going to have to add them to all pmu/format
things.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/