Re: [PATCH v2 1/2] leds-lm3530: set the value of max_brightness to 127

From: Linus Walleij
Date: Thu Jan 26 2012 - 06:53:44 EST


On Wed, Jan 25, 2012 at 10:40 AM, Kim, Milo <Milo.Kim@xxxxxx> wrote:

> Only 7 bits are used for the brightness. (register address : A0h)
> So the max_brightness property of lm3530 should be set to 127.
>
> On initializing registers, maximum initial brightness is limited to 'max_brightness'.
>
> Division-by-two is removed on updating the value of brightness.
> This arithmetic is not necessary because the range of brightness is 0 ~ 127.
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@xxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

On *this* exact patch.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/