Re: [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap

From: Julia Lawall
Date: Thu Jan 26 2012 - 06:24:19 EST




On Thu, 26 Jan 2012, Mark Brown wrote:

On Tue, Jan 24, 2012 at 09:45:26PM +0100, Julia Lawall wrote:

The various devm_ functions allocate memory that is released when a driver
detaches. This patch uses these functions for data that is allocated in
the probe function of a platform device and is only freed in the remove
function.

This is a really nice cleanup - I tried to apply it but unfortunately it
needs a rebase due to the change to use clk_prepare()/clk_unprepare()
which went in recently. Could you rebase against current -next please?

Could you tell me in more detail what the problem is? I pulled linux-next and regenerated the patch, but got exactly the same thing as before. I do see some calls to clk_prepare_enable in the code.

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/