Re: [PATCH] kconfig: fix new choices being skipped upon config update

From: Michal Marek
Date: Thu Jan 26 2012 - 05:06:43 EST


On 26.1.2012 10:26, Uwe Kleine-KÃnig wrote:
> On Mon, Jan 23, 2012 at 05:29:05PM -0500, Arnaud Lacombe wrote:
[...]
>> will not cause the choice to be considered as NEW, and thus not be asked. The
>> cause of this behavior is that choice's novelty are computed statically right
>> after the saved configuration has been read. At this point, the new dependency's
>> value is still unknown and asserted to be `no'. Moreover, no update to this
>> decision is made afterward.
>>
>> Correct this by dynamically evaluating a choice's novelty, and removing the
>> static evaluation.
>>
>> Cc: linux-kbuild@xxxxxxxxxxxxxxx
>> Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>,
>> Cc: Michal Marek <mmarek@xxxxxxx>
>> Cc: Uwe Kleine-Konig <u.kleine-koenig@xxxxxxxxxxxxxx>
>> Reported-by: Uwe Kleine-Konig <u.kleine-koenig@xxxxxxxxxxxxxx>
> Tested-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks, applied to kbuild.git#kconfig.


> (Please note the umlaut o in my name. If you have problems with that,
> please at least write Kleine-Koenig.)

Fixed.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/