Re: [PATCH] mm: vmscan: fix malused nr_reclaimed in shrinking zone

From: Hillf Danton
Date: Wed Jan 25 2012 - 22:19:17 EST


Hi Andrew

On Thu, Jan 26, 2012 at 9:00 AM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> I'm thinking we have a bit of code rot happening here. ÂThis comment:
>
> Â Â Â Â Â Â Â Â/*
> Â Â Â Â Â Â Â Â * On large memory systems, scan >> priority can become
> Â Â Â Â Â Â Â Â * really large. This is fine for the starting priority;
> Â Â Â Â Â Â Â Â * we want to put equal scanning pressure on each zone.
> Â Â Â Â Â Â Â Â * However, if the VM has a harder time of freeing pages,
> Â Â Â Â Â Â Â Â * with multiple processes reclaiming pages, the total
> Â Â Â Â Â Â Â Â * freeing target can get unreasonably large.
> Â Â Â Â Â Â Â Â */
>
> seems to have little to do with the code which it is trying to
> describe. ÂOr at least, I'm not sure this is the best we can possibly
> do :(
>

Try to do it soon 8-)

>
> Also, your email client is adding MIME goop to the emails which mine
> (sylpheed) is unable to decrypt. ÂIt turns "=" into "=3D" everywhere.
> This:
>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: quoted-printable
>
> I blame sylpheed for this, but if you can make it stop, that would make
> my life easier, and perhaps others.
>

More care will take gmail later on.

Thanks
Hillf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/