Re: [PATCH 3/3] mm: adjust rss counters for migration entiries

[Andrew Morton]

On Wed, 25 Jan 2012 15:01:38 -0800 (PST)
Hugh Dickins <hughd@xxxxxxxxxx> wrote:

> > > > : From: Konstantin Khlebnikov<khlebnikov@xxxxxxxxxx>
> > > > : Subject: mm: postpone migrated page mapping reset
> > > > :
> > > > : Postpone resetting page->mapping until the final
> > > > remove_migration_ptes().
> > > > : Otherwise the expression PageAnon(migration_entry_to_page(entry)) does
> > > > not
> > > > : work.
> > > > :
> > > > : Signed-off-by: Konstantin Khlebnikov<khlebnikov@xxxxxxxxxx>
> > > > : Cc: Hugh Dickins<hughd@xxxxxxxxxx>
> > > > : Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@xxxxxxxxxxxxxx>
> > > 
> > > Isn't this one actually an essential part of the fix?  It should have
> > > been part of the same patch, but you split them apart, now Andrew has
> > > reordered them and pushed one part to 3.3, but this needs to go in too?
> > > 
> > 
> > Oops. I missed that. Yes. race-fix does not work for anon-memory without that
> > patch.
> > But this is non-fatal, there are no new bugs.
> 
> Non-fatal and no new bug, yes, but it makes the fix which has already
> gone in rather less of a fix than was intended (it'll get the total right,
> but misreport anon as file).  Andrew, please add this one to your next
> push to Linus - thanks.

Shall do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/