Re: [PATCH v2] sched: Accelerate "pick_next_entity" under specialcondition

[Peter Zijlstra]

On Tue, 2012-01-17 at 11:04 +0800, Michael Wang wrote:
> 
> > Then what if condition 1 is true now?
> 
> We can see in original code, even condition 1 is true, we
> still will use value3 if condition3 is true, like this:
> 
> original:
> 
> condition1      condition3      result
> true            true            value3
> true            false           value1
> 
> That means if condition3 is true, we don't care whether
> condition1 is true or not because we will finally use value3.

Right, so from the original 8 possible states we used to evaluate 3*8 =
24 conditionals. The new code will reduce this to 1*4 + 2*2 + 2*3 = 14.

Now I guess the question is if it matters for the modal or average
state.

I've applied the patch since it can't be worse, but I've no idea if it
matters or not in practice.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/