Re: [RFC PATCH v1 1/2] sched: unified sched_powersavings sysfstunable

From: Peter Zijlstra
Date: Wed Jan 25 2012 - 09:57:26 EST


On Mon, 2012-01-16 at 21:52 +0530, Vaidyanathan Srinivasan wrote:
> +enum powersavings_level {
> + POWERSAVINGS_DISABLED = 0, /* Max performance */
> + POWERSAVINGS_DEFAULT, /* Kernel default policy, automatic powersave */
> + /* vs performance tradeoff */
> + POWERSAVINGS_MAX /* Favour power savings over peformance */
> };

I don't like that, I can get, OFF, AUTO, ON, but to overload that with
different policies for AUTO and ON just reeks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/