Re: [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device

From: Namjae Jeon
Date: Wed Jan 25 2012 - 00:38:11 EST


>> >> +
>> >> +static int mmc_blk_issue_packed_rd(struct mmc_queue *mq,
>> >> + Â Â Â Â Â Â Â struct mmc_queue_req *mq_rq)
>> >> +{
>> >> + Â Â Â struct mmc_blk_data *md = mq->data;
>> >> + Â Â Â struct mmc_card *card = md->queue.card;
>> >> + Â Â Â int status, ret = -EIO, retry = 2;
Hi. Seungwon.
First Thansk for your reply.
There is one more my review comment.
I think that EIO of ret is not needed. there is no case to be skipped
if/ese condition in do while loop.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/