RE: [PATCH 3/7] leds-lm3530: add 'is_vin_always_on' in thelm3530_platform_data

From: Kim, Milo
Date: Tue Jan 24 2012 - 20:58:10 EST


OK, I see. I'll try to follow design patterns for the regulator.
Thanks a lot for your comment.

Best Regards,
Milo -


-----Original Message-----
From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx]
Sent: Tuesday, January 24, 2012 4:31 AM
To: Linus Walleij
Cc: Kim, Milo; shreshthakumar.sahu@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; rpurdie@xxxxxxxxx
Subject: Re: [PATCH 3/7] leds-lm3530: add 'is_vin_always_on' in the lm3530_platform_data

On Mon, Jan 23, 2012 at 08:13:18PM +0100, Linus Walleij wrote:

> As far as I know we want to get rid of different design patterns
> avoiding the regulator interface. The way forward for this is
> either:

> (A) Provide a fixed voltage regulator in your platform for this
> device (AFAIK the voltage does not even have to be correct)
> (B) Enable dummy regulators in your platform

> (A) is more elegant.

Yeah, regulator usage should essentially never be conditional at a
driver level unless there's actual optional supplies in the hardware.
The situation has never been any different to that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/