Re: [PATCH] debugfs: add mode, uid and gid options

[Greg KH]

On Mon, Jan 16, 2012 at 05:06:21PM +0100, Ludwig Nussel wrote:
> Cautious admins may want to restrict access to debugfs. Currently a
> manual chown/chmod e.g. in an init script is needed to achieve that.
> Distributions that want to make the mount options configurable need
> to add extra config files. By allowing to set the root inode's uid,
> gid and mode via mount options no such hacks are needed anymore.
> Instead configuration becomes straight forward via fstab.
> 
> Signed-off-by: Ludwig Nussel <ludwig.nussel@xxxxxxx>

Oops, no, I didn't apply this as I get a compiler warning with it
applied:

fs/debugfs/inode.c:244:2: warning: initialization from incompatible pointer type [enabled by default]
fs/debugfs/inode.c:244:2: warning: (near initialization for âdebugfs_super_operations.show_optionsâ) [enabled by default]

Please fix this and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/