Re: [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap

From: Julia Lawall
Date: Tue Jan 24 2012 - 15:36:25 EST


On Tue, 24 Jan 2012, Mark Brown wrote:

On Tue, Jan 24, 2012 at 06:29:13PM +0100, Julia Lawall wrote:

if (IS_ERR(saif->clk)) {
- ret = PTR_ERR(saif->clk);
dev_err(&pdev->dev, "Cannot get the clock: %d\n",
ret);
- goto failed_clk;
+ return PTR_ERR(saif->clk);

Looks like the transformation is overly enthusiastic here - the
assignment to ret is removed but ret is used in the log message.

Uh, no, I did that stupid thing by hand. I'll fix it. Thanks.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/