Re: [PATCH 1/7] PCI: Make sriov work with hotplug remove

From: Linus Torvalds
Date: Mon Jan 23 2012 - 17:38:32 EST


On Mon, Jan 23, 2012 at 2:30 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>
> for_each_prev_safe is working...
>
> please check attached patch...

Ugh. This is probably the best one so far, but the whole thing is
really confused.

Why does "stop_bus_device" do a "remove" for VF's at _all_? Why is
everything about those stupid virtual devices so screwed up? Why do we
have separate "stop" and "remove" methods, and then the "stop" does a
remove? WTF?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/