Re: [PATCH] sched/stats: Keep legacy array expiration field to zero.

From: Rakib Mullick
Date: Mon Jan 23 2012 - 11:21:03 EST


On Mon, Jan 23, 2012 at 6:56 PM, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:
> On Thu, 2012-01-19 at 22:37 +0600, Rakib Mullick wrote:
>> A patch (https://lkml.org/lkml/2012/1/12/224) was sent previously to
>> update scheduler stat documentation to address array expiration
>> field's use. Then Ingo suggest that, we should also make sure that
>> we're exporting a value of zero. So, this patch does those
>> accordingly.
>
>
> This is not a valid changelog

Ok, I'll elaborate the changelog. (Actually, I had my finger crossed :) )
>
> This leaves sched_switch completely unused:
>
> # git grep -e "\<sched_switch\>"  kernel/sched/
> kernel/sched/debug.c:   P(sched_switch);
> kernel/sched/sched.h:   unsigned int sched_switch;
> kernel/sched/stats.c:               rq->sched_switch, rq->sched_count, rq->sched_goidle,
>
> Best kill that too
>
I asked on previous posting about removing rq->sched_switch. But
didn't get any specific answer. Anyway, will do it.

Thanks,
Rakib
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/