Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set

From: Julia Lawall
Date: Sat Jan 21 2012 - 02:45:23 EST




On Sat, 21 Jan 2012, Brice Goglin wrote:

Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back.

Tested-by: Brice Goglin <Brice.Goglin@xxxxxxxx>



Le 21/01/2012 00:10, Greg Dietsche a écrit :
This patch reverts a portion of d0bc1fb4 so that coccicheck will
work properly when C=1 or C=2.

Reported-by: Brice Goglin <Brice.Goglin@xxxxxxxx>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@xxxxxxx>

Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

---
scripts/coccicheck | 13 ++++---------
1 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/scripts/coccicheck b/scripts/coccicheck
index 3c27764..823e972 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then
# FLAGS="-ignore_unknown_options -very_quiet"
# OPTIONS=$*

- if [ "$KBUILD_EXTMOD" = "" ] ; then
- # Workaround for Coccinelle < 0.2.3
- FLAGS="-I $srctree/include -very_quiet"
- shift $(( $# - 1 ))
- OPTIONS=$1
- else
- echo M= is not currently supported when C=1 or C=2
- exit 1
- fi
+# Workaround for Coccinelle < 0.2.3
+ FLAGS="-I $srctree/include -very_quiet"
+ shift $(( $# - 1 ))
+ OPTIONS=$1
else
ONLINE=0
FLAGS="-very_quiet"