Re: [PATCH 2/2] mfd: Add support for multiple s5m devices

[Mark Brown]

On Fri, Jan 20, 2012 at 04:09:12PM +0900, Sangbeom Kim wrote:

Reviewed-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

> +	switch (s5m87xx->device_type) {
> +	case S5M8751X:
> +		ret = mfd_add_devices(s5m87xx->dev, -1, s5m8751_devs,
> +					ARRAY_SIZE(s5m8751_devs), NULL, 0);
> +		break;

Does the hardware have ID registers you can use to confirm if the user
got the right device?  Cut'n'pasting of machine definitions can be a bit
error prone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/